[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    review request concerning KInfoCenter->summary page
From:       Hugo Pereira Da Costa <hugo () oxygen-icons ! org>
Date:       2010-06-04 18:29:08
Message-ID: 201006041229.08991.hugo () oxygen-icons ! org
[Download RAW message or body]

Hello,

I attended to submit this suggested patch to kde reviewboard, but did not find 
to which group/people I should assign it.

It replaces the home-made round flat boxes in kinfocenter summary page by 
standard qgroupboxes. See screenshots at:

current: http://www.flickr.com/photos/hugo-oxygen-icons-org/4669216175/ 
patched: http://www.flickr.com/photos/hugo-oxygen-icons-org/4669839282/

The patch applies to 
/trunk/KDE/kdebase/workspace/kinfocenter/Modules/infosummary

In general, Nuno and I think that apps should try use 'standard' widgets as 
much as possible, rather than reimplementing their own, for consistency sake 
(inside a given style with respect to other elements, and also across 
applications). 

Side note: there is another review request in preparation that addresses the 
labels, but might break string freeze (softly)

Comments (or instruction on where/to whom I should submit this at reviewboard) 
highly appreciated,

Thanks !

Hugo

["defaultboxwidget.diff" (text/x-patch)]

Index: defaultboxwidget.cpp
===================================================================
--- defaultboxwidget.cpp	(revision 1134620)
+++ defaultboxwidget.cpp	(working copy)
@@ -31,8 +31,6 @@
   m_layout->setAlignment(Qt::AlignTop|Qt::AlignLeft);
   m_layout->setSpacing(10);
   
-  setStyleSheet("QFrame#OuterFrame { border: 2px solid grey; border-radius: 10px; };");
-  
   createDisplay();
 }
 
Index: defaultboxwidget.h
===================================================================
--- defaultboxwidget.h	(revision 1134620)
+++ defaultboxwidget.h	(working copy)
@@ -24,14 +24,14 @@
 #define __DEFAULTBOXWIDGET__
 
 //QT
-#include <QFrame>
+#include <QGroupBox>
 #include <QGridLayout>
 #include <QLabel>
 
 //KDE
 #include <KIcon>
 
-class DefaultBoxWidget : public QFrame
+class DefaultBoxWidget : public QGroupBox
 {
   Q_OBJECT
  


[prev in list] [next in list] [prev in thread] [next in thread]