[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: DBus spec compliant service names
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-06-01 23:36:18
Message-ID: 20100601233618.13719.43129 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4203/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

According to the DBus spec ( \
http://dbus.freedesktop.org/doc/dbus-specification.html ), services on the \
bus may only have [a-zA-Z0-9_] in them, must start with a letter and be no \
longer than 255 characters. For apps with illegal characters in them, such \
as plasma-desktop and plasma-netbook, this causes warnings to be printed \
that give concern to some users. It also means that apps that are strict \
about these things may not show these services. Right now dbus-daemon does \
not enforce this requirement, so it's a theoretical-in-practice problem at \
this point as far as I can tell.

This patch makes the names compliant ... but will spark a lot of changes \
for us in workspace (all those calls from control panels, plasmoids, etc. \
to org.kde.plasma-desktop for instance) as well as patches to apps such as \
kquitapp (so that it would turn plasma-desktop into plasma_desktop \
internally). It would also break any scripts that assume names like \
"plasma-desktop". I'm not sure it's worth doing for this reason. It was an \
easy patch to do, however, so I figured I should at least float it past the \
rest of the kdelibs developers. Thoughts?


This addresses bug 240358.
    https://bugs.kde.org/show_bug.cgi?id=240358


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.cpp 1130620 
  /trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp 1130620 

Diff: http://reviewboard.kde.org/r/4203/diff


Testing
-------


Thanks,

Aaron


[prev in list] [next in list] [prev in thread] [next in thread]