From kde-core-devel  Sat May 29 21:32:17 2010
From: "Christoph Feck" <christoph () maxiom ! de>
Date: Sat, 29 May 2010 21:32:17 +0000
To: kde-core-devel
Subject: Re: Review Request: Avoid setting a style that is already set
Message-Id: <20100529213217.5038.7335 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=127516873119284


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4178/#review5913
-----------------------------------------------------------

Ship it!


Oh, and I always wondered about debug messages from Oxygen, even when I do not use it :)

The NULL check is unnecessary, Qt makes sure there is a style set (even if it is a built-in style), it will assert otherwise.

- Christoph


On 2010-05-29 20:28:39, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4178/
> -----------------------------------------------------------
> 
> (Updated 2010-05-29 20:28:39)
> 
> 
> Review request for kdelibs and Olivier Goffart.
> 
> 
> Summary
> -------
> 
> Qt is not smart enough not to avoid loading a style that is already set. This avoids a unneeded creation and deletion of the current style for me. It works for all styles since QStyleFactory::create does
>     if(ret)
>         ret->setObjectName(style);
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 1132095 
> 
> Diff: http://reviewboard.kde.org/r/4178/diff
> 
> 
> Testing
> -------
> 
> Started an app, it worked, Oxygen destructor was not called like it was before
> 
> 
> Thanks,
> 
> Albert
> 
>