From kde-core-devel Thu May 27 14:23:22 2010 From: Thiago Macieira Date: Thu, 27 May 2010 14:23:22 +0000 To: kde-core-devel Subject: Re: Review Request: Workaround for non-thread-safety of Message-Id: <201005271623.22938.thiago () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=127497030421357 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart8182228.v1oVFe5H2k" --nextPart8182228.v1oVFe5H2k Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Note that there is a fix for the issue. I will apply it to libdbus-1. I recommend all distributions upgrade to D-Bu= s=20 1.4.0 as soon as it's out (there's no schedule for it). Em Quinta-feira 27 Maio 2010, =C3=A0s 15:55:33, Sebastian Trueg escreveu: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4166/ > ----------------------------------------------------------- >=20 > Review request for kdelibs. >=20 >=20 > Summary > ------- >=20 > As many of us experienced already QDBusConnection is not thread-safe. As > you can see in Qt bug 7475 > (http://bugreports.qt.nokia.com/browse/QTBUG-7475) this is not Qt's fault > but an issue in libdbus which has been reported a rather long time ago > (https://bugs.freedesktop.org/show_bug.cgi?id=3D17754). In Nepomuk we work > around this problem using a pool of connections, one for each thread. This > is no perfect solution but at least we get no more crashes. The same > applies to KSycoca, too. It is used in multi-threading situations at least > in Dolphin. Thus, this patch moves the DBusConnectionPool to kdecore, > making it privately available to all kdelibs components. >=20 >=20 > Diffs > ----- >=20 > trunk/KDE/kdelibs/kdecore/util/dbusconnectionpool.cpp PRE-CREATION > trunk/KDE/kdelibs/kdecore/CMakeLists.txt 1130392 > trunk/KDE/kdelibs/kdecore/sycoca/ksycoca.cpp 1130392 > trunk/KDE/kdelibs/kdecore/util/dbusconnectionpool.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/core/CMakeLists.txt 1130392 > trunk/KDE/kdelibs/nepomuk/core/dbusconnectionpool.h 1130392 > trunk/KDE/kdelibs/nepomuk/core/dbusconnectionpool.cpp 1130392 >=20 > Diff: http://reviewboard.kde.org/r/4166/diff >=20 >=20 > Testing > ------- >=20 >=20 > Thanks, >=20 > Sebastian =2D-=20 Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Senior Product Manager - Nokia, Qt Development Frameworks PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 --nextPart8182228.v1oVFe5H2k Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQBL/oBaM/XwBW70U1gRAheVAJ4m4kg2H2N6U481IZDaeBHErq9ixwCffZdJ zrAB2w03UL2JMz7jyThkYqk= =rIqL -----END PGP SIGNATURE----- --nextPart8182228.v1oVFe5H2k--