From kde-core-devel  Fri May 14 19:47:02 2010
From: Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date: Fri, 14 May 2010 19:47:02 +0000
To: kde-core-devel
Subject: Re: About the KRunner webshortcut plugin...
Message-Id: <201005142147.04065 () thufir ! ingo-kloecker ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=127393196000646
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart254779378.QAYUrvm061"

--nextPart254779378.QAYUrvm061
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable

On Friday 14 May 2010, Michael Pyne wrote:
> On Thursday, May 13, 2010 15:29:57 Andreas Hartmetz wrote:
> > On Thursday 13 May 2010 18:50:53 Aaron J. Seigo wrote:
> > > On May 13, 2010, Ingo Kl=F6cker wrote:
> > > > I should probably file a bug report for this: Web shortcuts
> > > > never worked for me in KRunner (currently using 4.4.2 on
> > > > openSUSE 11.2). When I type "gg:test" nothing happens. KRunner
> > > > simply sits there showing no runners to chose from. In
> > > > Konqueror web shortcuts work.
> > >=20
> > > first ensure that the webshortcuts runner is enabled in the
> > > krunner config diaog.

Check. (Of course, I had checked this already multiple times before.)


> > > if it is, then something pretty odd/interesting is happening on
> > > your system since it works for others very reliably. maybe put
> > > some debug into
> > > kdebase/workspace/plasma/generic/runners/webshorcuts/webshortcutr
> > > unner.c pp in the match method.
> >=20
> > I have the same problem on two computers but not on my main desktop
> > PC. My main desktop has four cores, the other two have one. Maybe
> > that is the important difference?
>=20
> Also make sure that those particular web shortcuts are enabled in
> Konqueror.

Check. (I had checked this also already multiple times before.)


> Somehow a few of the ones I use all the time (including gg:) got
> disabled in the Web Shortcuts KCM. Konqueror apparently ignores that
> and so they still worked, but the web shortcut runner doesn't and
> therefore ignored those prefixes.

Same here. Enabling them didn't help though.

Maybe it's a problem with config migration. I migrated straight from 3.5=20
to 4.4 beta 1.

Hmm, I had a quick look at=20
kdebase/workspace/plasma/generic/runners/webshorcuts/webshortcutrunner.cpp

WebshortcutRunner::loadDelimiter() loads the KeywordDelimiter from=20
kuriikwsfilterrc.

    m_delimiter =3D generalgroup.readEntry("KeywordDelimiter",=20
QString(':'));

Obviously, it assumes this delimiter to be a character with ':' being=20
the default. But my kuriikwsfilterrc contains
KeywordDelimiter=3D58

Of course, 58 is the ASCII code of ':'.

Looking for other parties interested in KeywordDelimiter I found

in kdelibs/khtml/khtml_ext.cpp:
  const char keywordDelimiter =3D cg.readEntry("KeywordDelimiter",=20
static_cast<int>(':'));

in kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.cpp:
  m_cKeywordDelimiter =3D QString(group.readEntry("KeywordDelimiter",=20
":")).at(0).toLatin1();                                                    =
                                                  =20

in kdebase/runtime/kurifilter-plugins/ikws/ikwsopts.cpp:
  QString delimiter =3D group.readEntry ("KeywordDelimiter", ":");
and
  group.writeEntry("KeywordDelimiter", QString(delimiter() ));

in kdebase/runtime/kurifilter-plugins/tests/kurifiltertest.cpp:
  cfg.writeEntry( "KeywordDelimiter", QString(s_delimiter) );


Conclusion:
Either khtml_ext is wrong or all other users of KeywordDelimiter are=20
wrong.

The following fixed the problem for me:
kwriteconfig --file kuriikwsfilterrc --group General --key=20
KeywordDelimiter ':'

I wonder what will break now due to the wrong code in khtml_ext.cpp.


Regards,
Ingo

--nextPart254779378.QAYUrvm061
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)

iEYEABECAAYFAkvtqLcACgkQGnR+RTDgudjTcACeP9G5DOwU4XDuJcsdUUAH1i7c
VDMAoJwWiQBRyRkuLwD9gz1R65XbTKiy
=6AhV
-----END PGP SIGNATURE-----

--nextPart254779378.QAYUrvm061--