[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Provide symbolic link destination as additional
From:       "Peter Penz" <peter.penz () gmx ! at>
Date:       2010-05-08 22:36:33
Message-ID: 20100508223633.23862.73189 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3912/#review5533
-----------------------------------------------------------


Thanks Frank! From my point of view there are no objections to commit the \
patch on Monday (including Sebastian's patch from \
http://reviewboard.kde.org/r/3354). I hope that Fredrik can give an \
official "Ship It"...

- Peter


On 2010-05-07 17:20:22, Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3912/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 17:20:22)
> 
> 
> Review request for kdelibs, Peter Penz and Fredrik Höglund.
> 
> 
> Summary
> -------
> 
> I propose to provide the destination of a symbolic link as additional \
> information in KFileItemDelegate. This will enable us to provide that as \
> a column in Dolphin's and Konqueror's Details View, which has been \
> requested a couple of times (note that KDE 3 had that feature). 
> Like Sebastian who filed the related request \
> http://reviewboard.kde.org/r/3354/, I think that this information may be \
> useful outside Dolphin and should therefore be provided in \
> KFileItemDelegate. Additionally, Dolphin currently stores the additional \
> columns which are enabled in a KFileItemDelegate::InformationList, which \
> means that not adding this information in KFID, but only in Dolphin \
> itself would require a total rewrite of the code that stores the \
> additional columns. 
> Any feedback is appreciated. If nobody (in particular Fredrik) objects, \
> I'd like to commit this on Monday to make sure that we can get this \
> feature into 4.5. I could include Sebastian's patch in my commit if there \
> is agreement that both additions to KFID are desirable. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.h 1123638 
> /trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1123638 
> 
> Diff: http://reviewboard.kde.org/r/3912/diff
> 
> 
> Testing
> -------
> 
> I've got a patch for Dolphin that makes use of this in the Details View - \
> works as expected for me. 
> 
> Thanks,
> 
> Frank
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]