[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Route (un)mounting errors via knotify to the
From: "Jacopo De Simoi" <wilderkde () gmail ! com>
Date: 2010-05-06 21:15:15
Message-ID: 20100506211515.31117.70439 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3895/
-----------------------------------------------------------
(Updated 2010-05-06 21:15:15.179530)
Review request for kdelibs, Aaron Seigo, Marco Martin, and Olivier Goffart.
Changes
-------
Fixed style and svn added the file hardwarenotifications.notifyrc which I forgot \
before :)
Olivier, your observation about dbus is indeed correct:
we need to invert the instantiation of the watcher and the first check. In fact the \
same patch should be applied to notifybypopup.cpp, from which I took the code logic.
Better to patch the two files at once?
Summary
-------
This patch adds a solid device watcher to knotify; the class watches for errors and \
sends them either to a dbus interface (offered by a plasma dataengine) or, if the \
interface is not found, thru regular notifications.
Diffs (updated)
-----
trunk/KDE/kdebase/runtime/knotify/CMakeLists.txt 1121868
trunk/KDE/kdebase/runtime/knotify/hardwarenotifications.notifyrc PRE-CREATION
trunk/KDE/kdebase/runtime/knotify/knotify.cpp 1121868
trunk/KDE/kdebase/runtime/knotify/ksolidnotify.h PRE-CREATION
trunk/KDE/kdebase/runtime/knotify/ksolidnotify.cpp PRE-CREATION
Diff: http://reviewboard.kde.org/r/3895/diff
Testing
-------
It needs a patch to plasma to work properly, will file that soon to the revboard.
With that patch, it works well.
Thanks,
Jacopo
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic