[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Middle click opens a folder in a new tab in the
From:       "Peter Penz" <peter.penz () gmx ! at>
Date:       2010-05-04 18:54:33
Message-ID: 20100504185433.10999.38646 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3859/#review5401
-----------------------------------------------------------

Ship it!


Thanks Todd, the patch looks good and I've just committed it.

- Peter


On 2010-05-01 18:28:36, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3859/
> -----------------------------------------------------------
> 
> (Updated 2010-05-01 18:28:36)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This adds support for middle-clicking on the breadcrumb folder menus to open them \
> in a new tab.  This adds what I feel is useful functionality and makes the menus \
> behave consistently with the rest of the breadcrumb bar.   
> Note that middle-clicking does not close the menu.  This would both be more \
> difficult to implement and, I think, inferior in terms of functionality.  Doing it \
> this way allows people to open multiple tabs without re-opening the menu (or, \
> better yet, a sub-menu).  Further, simply clicking outside the menu closes it \
> (which you would need to do to get anything done anyway).  So there is not much \
> cost to doing it this way for people who only want to open one tab but there is a \
> large benefit for people who want to open multiple tabs. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kfile/kurlnavigatorbutton.cpp 1121251 
> /trunk/KDE/kdelibs/kfile/kurlnavigatorbutton_p.h 1121251 
> /trunk/KDE/kdelibs/kfile/kurlnavigatormenu.cpp 1121251 
> /trunk/KDE/kdelibs/kfile/kurlnavigatormenu_p.h 1121251 
> 
> Diff: http://reviewboard.kde.org/r/3859/diff
> 
> 
> Testing
> -------
> 
> Middle click opens a new tab both on the main menu and the new "more" sub-menus.  \
> I'm not sure what else I can test, the patch is fairly straightforward. 
> 
> Thanks,
> 
> Todd
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]