[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: keyboard2 moved to kdereview
From:       Andriy Rysin <arysin () gmail ! com>
Date:       2010-05-02 15:19:40
Message-ID: q2x3e02eb611005020819v4be6e480wd53a510b251bc176 () mail ! gmail ! com
[Download RAW message or body]

2010/5/2 Ingo Kl=F6cker <kloecker@kde.org>

> On Saturday 01 May 2010, Andriy Rysin wrote:
> > 2010/5/1 Ingo Kl=F6cker <kloecker@kde.org>
> >
> > > On Friday 30 April 2010, Andriy Rysin wrote:
> > > > 2010/4/29 Aaron J. Seigo <aseigo@kde.org>
> > > >
> > > > > On April 25, 2010, Andriy Rysin wrote:
> > > > > > drawing the text I need to find a way to leave the taskbar
> > > > > > background (but this was also the problem before).
> > > > >
> > > > > looking at the code in Flags, i think i can see the problem:
> > > > > you probably just
> > > > > need to fill the pixmap first with Qt::transparent so the
> > > > > background is, well,
> > > > > transparent :) then you can paint the text, flag, etc over top
> > > > > of that.
> > > >
> > > > yep, I found it today and already pushed the code for
> > > > transparency The problem with text over the flag is that it's
> > > > hard to find the right way to paint readable text with all the
> > > > possible flag colors and their combination. So for now it'll be
> > > > either text or flag, so far the early feedback was pretty
> > > > positive.
> > >
> > > Drawing a dark outline around white text usually is a good solution
> > > for this problem. To get something like an outline which also
> > > looks good for small fonts you could draw the text in black, then
> > > blur it and then draw the text in white over the blurred black
> > > text.
> >
> > That's very similar to what was done before, though as flags are
> > quite different in size/colors/darkness, the white text was drawn with
> > black one shifted 1px for a shadow, plus flags had to be dimmed
> > otherwise text was not readable anyway. Even though the final text
> > image was more or less readable on most flags it was quite ugly both
> > code- and look-wise...
> > I'm really starting to like "flag-only"/"text-only" solution  better.
>
> You are probably right. Did you think about putting the text into a
> tooltip in case of showing the flags only?
>
> Yes, the tooltip is always set whether it's text or icon shown. The systr=
ay
had a tooltip before and I've just added tooltip for plasma applet. For som=
e
reason though tooltip does not appear in lockdlg in screenlocker. :(

Andriy

[Attachment #3 (text/html)]

<div class="gmail_quote">2010/5/2 Ingo Klöcker <span dir="ltr">&lt;<a \
href="mailto:kloecker@kde.org">kloecker@kde.org</a>&gt;</span><br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> <div><div></div><div class="h5">On Saturday 01 May \
2010, Andriy Rysin wrote:<br> &gt; 2010/5/1 Ingo Klöcker &lt;<a \
href="mailto:kloecker@kde.org">kloecker@kde.org</a>&gt;<br> &gt;<br>
&gt; &gt; On Friday 30 April 2010, Andriy Rysin wrote:<br>
&gt; &gt; &gt; 2010/4/29 Aaron J. Seigo &lt;<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt;<br> &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; On April 25, 2010, Andriy Rysin wrote:<br>
&gt; &gt; &gt; &gt; &gt; drawing the text I need to find a way to leave the \
taskbar<br> &gt; &gt; &gt; &gt; &gt; background (but this was also the problem \
before).<br> &gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; looking at the code in Flags, i think i can see the problem:<br>
&gt; &gt; &gt; &gt; you probably just<br>
&gt; &gt; &gt; &gt; need to fill the pixmap first with Qt::transparent so the<br>
&gt; &gt; &gt; &gt; background is, well,<br>
&gt; &gt; &gt; &gt; transparent :) then you can paint the text, flag, etc over \
top<br> &gt; &gt; &gt; &gt; of that.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; yep, I found it today and already pushed the code for<br>
&gt; &gt; &gt; transparency The problem with text over the flag is that it&#39;s<br>
&gt; &gt; &gt; hard to find the right way to paint readable text with all the<br>
&gt; &gt; &gt; possible flag colors and their combination. So for now it&#39;ll \
be<br> &gt; &gt; &gt; either text or flag, so far the early feedback was pretty<br>
&gt; &gt; &gt; positive.<br>
&gt; &gt;<br>
&gt; &gt; Drawing a dark outline around white text usually is a good solution<br>
&gt; &gt; for this problem. To get something like an outline which also<br>
&gt; &gt; looks good for small fonts you could draw the text in black, then<br>
&gt; &gt; blur it and then draw the text in white over the blurred black<br>
&gt; &gt; text.<br>
&gt;<br>
&gt; That&#39;s very similar to what was done before, though as flags are<br>
&gt; quite different in size/colors/darkness, the white text was drawn with<br>
&gt; black one shifted 1px for a shadow, plus flags had to be dimmed<br>
&gt; otherwise text was not readable anyway. Even though the final text<br>
&gt; image was more or less readable on most flags it was quite ugly both<br>
&gt; code- and look-wise...<br>
&gt; I&#39;m really starting to like &quot;flag-only&quot;/&quot;text-only&quot; \
solution  better.<br> <br>
</div></div>You are probably right. Did you think about putting the text into a<br>
tooltip in case of showing the flags only?<br><br></blockquote><div>Yes, the tooltip \
is always set whether it&#39;s text or icon shown. The systray had a tooltip before \
and I&#39;ve just added tooltip for plasma applet. For some reason though tooltip \
does not appear in lockdlg in screenlocker. :(<br> <br>Andriy<br><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic