[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix loss of formatting when removing a link from a
From:       "Stephen Kelly" <steveire () gmail ! com>
Date:       2010-04-30 12:21:28
Message-ID: 20100430122128.16805.86780 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3609/#review5324
-----------------------------------------------------------

Ship it!


Looks fine.

I'll commit this now.

- Stephen


On 2010-04-24 12:01:27, Jason Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3609/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 12:01:27)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KRichTextEdit derived editors would remove all formatting when a link was removed \
> from the text, not just the link related formatting. This patch allows the text to \
> retain its non-link related formatting, and also cleans up the overall \
> KRichTextEdit::updateLink method to make the logic a little simpler. 
> 
> This addresses bug 234439.
> https://bugs.kde.org/show_bug.cgi?id=234439
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.h 1116838 
> /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp 1116838 
> /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1116838 
> 
> Diff: http://reviewboard.kde.org/r/3609/diff
> 
> 
> Testing
> -------
> 
> Made a test case with a KRichTextEdit component to ensure the behavior was as \
> expected. 
> 
> Thanks,
> 
> Jason
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]