[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: keyboard2 moved to kdereview
From:       Andriy Rysin <arysin () gmail ! com>
Date:       2010-04-30 1:52:58
Message-ID: q2i3e02eb611004291852ia8363d9dnb3e5392258136c8c () mail ! gmail ! com
[Download RAW message or body]

2010/4/29 Aaron J. Seigo <aseigo@kde.org>

> On April 25, 2010, Andriy Rysin wrote:
>
> btw, some screenshots for the people on kde-usability (they don't always
> have
> a trunk build or kdereview available to them) might be nice for that list.
>
I've sent some screenshots to usability list about a month ago, and
unfortunately got no feedback

 > of course people who don't want flags would not care :) ). Also for
> > drawing the text I need to find a way to leave the taskbar background
> (but
> > this was also the problem before).
>
> looking at the code in Flags, i think i can see the problem: you probably
> just
> need to fill the pixmap first with Qt::transparent so the background is,
> well,
> transparent :) then you can paint the text, flag, etc over top of that.
>
yep, I found it today and already pushed the code for transparency
The problem with text over the flag is that it's hard to find the right way
to paint readable text with all the possible flag colors and their
combination. So for now it'll be either text or flag, so far the early
feedback was pretty positive.


> i also see that there is code looking for minimal font sizes such as:
>
>        if( fontSize < 6 ) {
>
> you probably want to be using KGlobalSettings::smallestReadableFont()
> instead.
>
ah, very nice, fixed and pushed

Thanks,
Andriy

[Attachment #3 (text/html)]

<div class="gmail_quote">2010/4/29 Aaron J. Seigo <span dir="ltr">&lt;<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt;</span><br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> <div class="im">On April 25, 2010, Andriy Rysin \
wrote:<br></div> <br>
btw, some screenshots for the people on kde-usability (they don&#39;t always have<br>
a trunk build or kdereview available to them) might be nice for that \
list.<br></blockquote><div>I&#39;ve sent some screenshots to usability list about a \
month ago, and unfortunately got no feedback<br><br></div><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;">

<div class="im">
&gt; of course people who don&#39;t want flags would not care :) ). Also for<br>
&gt; drawing the text I need to find a way to leave the taskbar background (but<br>
&gt; this was also the problem before).<br>
<br>
</div>looking at the code in Flags, i think i can see the problem: you probably \
just<br> need to fill the pixmap first with Qt::transparent so the background is, \
well,<br> transparent :) then you can paint the text, flag, etc over top of \
that.<br></blockquote><div>yep, I found it today and already pushed the code for \
transparency<br>The problem with text over the flag is that it&#39;s hard to find the \
right way to paint readable text with all the possible flag colors and their \
combination. So for now it&#39;ll be either text or flag, so far the early feedback \
was pretty positive.<br>  </div><blockquote class="gmail_quote" style="margin: 0pt \
0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

i also see that there is code looking for minimal font sizes such as:<br>
<br>
        if( fontSize &lt; 6 ) {<br>
<br>
you probably want to be using KGlobalSettings::smallestReadableFont() \
instead.<br></blockquote><div>ah, very nice, fixed and \
pushed<br><br>Thanks,<br>Andriy</div></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]