[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: keyboard2 moved to kdereview
From:       Andriy Rysin <arysin () gmail ! com>
Date:       2010-04-26 21:23:52
Message-ID: 30C21C65-98E8-4604-ACB4-22A59905803A () gmail ! com
[Download RAW message or body]

On Apr 26, 2010, at 13:59, Albert Astals Cid <aacid@kde.org> wrote:

> A Dilluns, 26 d'abril de 2010, Andriy Rysin va escriure:
>> Hi all
>>
>> I've moved new keyboard control module in kdereview under keyboard2  
>> name.
>>
>> :), so comments and suggestions are very welcome
>
> static const QString headers[] = {i18nc("layout map name", "Map"),
> i18n("Layout"), i18n("Variant"), i18n("Label")};
>
> This is most probably not going to work since the QString will be  
> constructed
> at the beginning of the app and the correct catalog won't be set  
> yet, so it
> would make sense to move these headers into  
> LayoutsTableModel::headerData and
> removing the static.
>
> Albert
>>

Thanks, I've pushed the change

Andriy
[prev in list] [next in list] [prev in thread] [next in thread]