[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Port the kio file conflict dialog to
From: "Todd" <toddrme2178 () gmail ! com>
Date: 2010-04-21 14:40:39
Message-ID: 20100421144039.2038.98266 () localhost
[Download RAW message or body]
> On 2010-04-21 06:05:01, Peter Penz wrote:
> > I've applied the patch locally and tested it when renaming images. From my point \
> > of view the result looks very good.
> > I had only a short look at the code: AFAIK it is common to add private methods + \
> > slots into the private class, however your change is binary compatible and the \
> > previous code did it similar. Maybe David Faure could give an official "ship it" \
> > or "no" (I'm not the maintainer of the class).
Thanks! I know you aren't the maintainer, but I thought it was important to include \
you since you developed the KFileMetaDataWidget and my code is based on your code in \
Dolphin so you would know best if I am doing something wrong with it.
- Todd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3674/#review5128
-----------------------------------------------------------
On 2010-04-20 05:27:40, Todd wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3674/
> -----------------------------------------------------------
>
> (Updated 2010-04-20 05:27:40)
>
>
> Review request for kdelibs and Peter Penz.
>
>
> Summary
> -------
>
> This patch switches the kio file conflict dialog (renamedialog) from using \
> mimetype-specific plugins for previews (sometimes) and file information to instead \
> using KFileMetaDataWidget for information and PreviewJob for previews.
> This approach has several advantages. First, it shares code with the rest of KDE, \
> so there is no need to write additional plugins for the renamedialog (which only \
> has two plugins currently). It also means that the appearance is consistent across \
> all file types, instead of having completely different layouts for different file \
> types. It also allows for nepomuk information to be displayed (when available). \
> It allows for more information than would fit comfortably (using scroll bars). And \
> finally it allows for previews and specialized information of file types for which \
> writing now plugins would be a waste of time (like text files and folders).
> As far as I can tell it should be backwards-compatible (if it isn't I'll fix it). \
> Using this approach does mean that renamedialogplugin (which I left alone for \
> compatibility) does not actually do anything anymore. However, the new widget \
> provides more information and provides it for more file types than the plugins.
> It does not give previews for videos, but the existing rename dialog doesn't either \
> so there is nothing lost there. PhononWidget handles this in Dolphin, but since it \
> is part of dolphin it is not available in kdelibs
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1116651
> /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1116651
>
> Diff: http://reviewboard.kde.org/r/3674/diff
>
>
> Testing
> -------
>
> It gives proper previews for images and text files, and proper icons for folders \
> and unknown binary files. It also gives the correct icon for video files, but no \
> preview (which is the same as the old widget).
> This is a complete rewrite of a large portion of the dialog, so I would very much \
> appreciate it if other people tested it as well.
>
> Thanks,
>
> Todd
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic