[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Better TagWidget in libnepomuk
From: "Sebastian Trueg" <trueg () kde ! org>
Date: 2010-04-20 13:44:08
Message-ID: 20100420134408.27617.44423 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3669/
-----------------------------------------------------------
(Updated 2010-04-20 13:44:08.659366)
Review request for kdelibs and Peter Penz.
Changes
-------
Simply fixed the diff which was missing one new header file.
Summary
-------
Nepomuk::TagWidget has been there forever but due to its being rather unintuitive and \
ugly (despite my efforts of making it fancy back in the day) it is not used at all. \
Since we have the class in kdelibs and a tagging widget is a typical thing to use I \
made another attempt at creating a generic one that apps ca use. It basically shows a \
list of checkboxes of the N most often used tags and has a button to show all tags. \
This button will bring up the exact dialog used in Dolphin and Gwenview (the one from \
KIO). So far the code cannot be shared since we cannot link libnepomuk against kio. \
But maybe we could do it the other way around and move the tag edit dialog into \
libnepomuk as a public class.
Anyway, this review request is about the new TagWidget and whether it has a chance to \
be used. I added a simple test app that allows to toy around with the widget.
Diffs (updated)
-----
trunk/KDE/kdelibs/includes/CMakeLists.txt 1116852
trunk/KDE/kdelibs/includes/Nepomuk/TagWidget PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/CMakeLists.txt 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/CMakeLists.txt 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/kautoscrollarea.h 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/kautoscrollarea.cpp 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/kblocklayout.h 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/kblocklayout.cpp 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/kedittagsdialog.cpp PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/kedittagsdialog_p.h PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/kmetadatatagwidget.h 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/kmetadatatagwidget.cpp 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/tagcheckbox.h PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/tagcheckbox.cpp PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/tagwidget.h PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/tagwidget.cpp PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/tagwidget_p.h PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/test/CMakeLists.txt 1116852
trunk/KDE/kdelibs/nepomuk/core/ui/test/tagwidgetapp.cpp PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/test/tagwidgettest.h PRE-CREATION
trunk/KDE/kdelibs/nepomuk/core/ui/test/tagwidgettest.cpp PRE-CREATION
Diff: http://reviewboard.kde.org/r/3669/diff
Testing
-------
Thanks,
Sebastian
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic