[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KNewstuff3 $XDG_DATA_HOME support
From:       "Frederik Gladhorn" <gladhorn () kde ! org>
Date:       2010-04-18 10:10:58
Message-ID: 20100418101058.20179.25334 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3598/#review5091
-----------------------------------------------------------

Ship it!


Looks good to me. Could you please add the description of the parameter here also: \
http://techbase.kde.org/Development/Tutorials/Collaboration/HotNewStuff/Introduction \
Thanks! Frederik

- Frederik


On 2010-04-16 13:24:29, Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3598/
> -----------------------------------------------------------
> 
> (Updated 2010-04-16 13:24:29)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Support for applications that want to install "Hot new stuff" into a directory \
> relative to $XDG_DATA_HOME. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/knewstuff/knewstuff3/core/installation.h 1113961 
> trunk/KDE/kdelibs/knewstuff/knewstuff3/core/installation.cpp 1113961 
> trunk/KDE/kdelibs/knewstuff/knewstuff3/downloaddialog.h 1113961 
> trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadwidget.h 1113961 
> 
> Diff: http://reviewboard.kde.org/r/3598/diff
> 
> 
> Testing
> -------
> 
> It works very nice. You could use Marble to test! (current svn version)
> 
> 
> Thanks,
> 
> Bastian
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]