[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Show meta information in KPropertiesDialog like
From:       "Peter Penz" <peter.penz () gmx ! at>
Date:       2010-04-13 19:10:59
Message-ID: 20100413191059.32731.38466 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3597/#review5016
-----------------------------------------------------------


Frank Reininghaus just gave me that hint, that the diff does not contain the moved \
files from kdelibs/kfile to kdelibs/kio/kfile. I've moved the files with 'svn move', \
but 'svn diff' for Subversion 1.6 does not show this information (there will be a \
switch in Subversion 1.7 called --show-copies-as-adds).

I'm unsure how to proceed, any suggestions would be welcome.

- Peter


On 2010-04-13 18:46:15, Peter Penz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3597/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 18:46:15)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> In KDE 4 the meta information tab from KPropertiesDialog has been disabled for \
> several reasons. The attached patch enables this functionality again, by using the \
> (just a few weeks ago added) class KFileMetaDataWidget. Some polishing is still \
> required, but the main intention to post this patch on the reviewboard is because I \
> had to move KFileMetaDataWidget + private classes from kdelibs/kfile to \
> kdelibs/kio/kfile to prevent a cyclic dependency. 
> I've recompiled kdelibs from scratch and cleaned the libs, bin, include-dirs, \
> however it would be great if someone could also try to apply the patch locally \
> before I commit. Thanks! 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kfile/kcommentwidget_p.h 1114071 
> trunk/KDE/kdelibs/kfile/CMakeLists.txt 1114071 
> trunk/KDE/kdelibs/kfile/kcommentwidget.cpp 1114071 
> trunk/KDE/kdelibs/kfile/kedittagsdialog.cpp 1114071 
> trunk/KDE/kdelibs/kfile/kedittagsdialog_p.h 1114071 
> trunk/KDE/kdelibs/kfile/kfilemetadataconfigurationwidget.h 1114071 
> trunk/KDE/kdelibs/kfile/kfilemetadataconfigurationwidget.cpp 1114071 
> trunk/KDE/kdelibs/kfile/kfilemetadataprovider.cpp 1114071 
> trunk/KDE/kdelibs/kfile/kfilemetadataprovider_p.h 1114071 
> trunk/KDE/kdelibs/kfile/kfilemetadatawidget.h 1114071 
> trunk/KDE/kdelibs/kfile/kfilemetadatawidget.cpp 1114071 
> trunk/KDE/kdelibs/kfile/kloadfilemetadatathread.cpp 1114071 
> trunk/KDE/kdelibs/kfile/kloadfilemetadatathread_p.h 1114071 
> trunk/KDE/kdelibs/kfile/knfotranslator.cpp 1114071 
> trunk/KDE/kdelibs/kfile/knfotranslator_p.h 1114071 
> trunk/KDE/kdelibs/kfile/ktaggingwidget.cpp 1114071 
> trunk/KDE/kdelibs/kfile/ktaggingwidget_p.h 1114071 
> trunk/KDE/kdelibs/kio/CMakeLists.txt 1114071 
> trunk/KDE/kdelibs/kio/kfile/kmetaprops.h 1114071 
> trunk/KDE/kdelibs/kio/kfile/kmetaprops.cpp 1114071 
> 
> Diff: http://reviewboard.kde.org/r/3597/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]