[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add support for AlphaChannel to KColorDialog
From: "Johannes Christenson" <mrchristenson () gmail ! com>
Date: 2010-04-13 6:23:04
Message-ID: 20100413062304.12903.74181 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3566/#review4996
-----------------------------------------------------------
I can't see any reason to treat the alpha channel different from other channels?
- Johannes
On 2010-04-11 20:15:26, Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3566/
> -----------------------------------------------------------
>
> (Updated 2010-04-11 20:15:26)
>
>
> Review request for Gwenview, kdelibs and usability.
>
>
> Summary
> -------
>
> Add an "alphaChannelEnabled" property to KColorDialog to support QColorDialog::ShowAlphaChannel.
> Requires the patch from http://reviewboard.kde.org/r/3565 to show the alpha gradient.
>
> Please comment on:
> * name/description of newly added methods in KColorDialog
> * visible "Alpha" label ("Opacity"?)
> * placement of widgets (yes, Alpha label should be aligned to RGB labels, but how?)
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 1113711
> /trunk/KDE/kdelibs/kdeui/colors/kcolordialog.h 1113786
> /trunk/KDE/kdelibs/kdeui/colors/kcolordialog.cpp 1113786
>
> Diff: http://reviewboard.kde.org/r/3566/diff
>
>
> Testing
> -------
>
> I used this to test integration with QColorDialog:
>
> #include <QtGui/QApplication>
> #include <QtGui/QColorDialog>
> #include <QtCore/QDebug>
>
> int main(int argc, char *argv[])
> {
> QApplication app(argc, argv);
> QColor color = QColorDialog::getColor(QColor(255, 0, 0, 100), 0, "Select ARGB Color",
> QColorDialog::ShowAlphaChannel);
> qDebug() << color;
> }
>
>
> Screenshots
> -----------
>
> KColorDialog with enabled AlphaChannel
> http://reviewboard.kde.org/r/3566/s/354/
>
>
> Thanks,
>
> Christoph
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic