[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add a confirmation window when emptying the trash
From:       "Tom Albers" <toma () kde ! org>
Date:       2010-03-29 14:55:42
Message-ID: 20100329145542.11869.97503 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3434/#review4736
-----------------------------------------------------------


Why is this needed? It is emptying the trash, so the user deleted the stuff first \
already. I see no need for another confirmation and another dialog. It is already a 2 \
step action to delete something permanently.

- Tom


On 2010-03-29 14:46:16, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3434/
> -----------------------------------------------------------
> 
> (Updated 2010-03-29 14:46:16)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> When the user empty the trash ( when using trash:/ in a desktop file ) there is no \
> confirmation window. This patch add a confirmation window.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/apps/lib/konq/konq_operations.cpp 1108647 
> /trunk/KDE/kdelibs/kio/kio/jobuidelegate.h 1108647 
> /trunk/KDE/kdelibs/kio/kio/jobuidelegate.cpp 1108647 
> 
> Diff: http://reviewboard.kde.org/r/3434/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]