[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Patch for KParts::BrowserRun to retain SSL
From:       "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date:       2010-03-24 19:06:03
Message-ID: 20100324190603.32151.7652 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3364/#review4667
-----------------------------------------------------------


It might make more sense to retain the SSL metadata in KIO::Job and resend it if \
necessary. Is there any reason against doing that? Or possibly new metadata has to be \
sent from the ioslave because the SSL metadata is related to the exact hostname...

- Andreas


On 2010-03-23 21:42:03, Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3364/
> -----------------------------------------------------------
> 
> (Updated 2010-03-23 21:42:03)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Currently if a KPart based application such as Konqueror calls \
> KParts::BrowserRun::scanFile to determine the mime-type of a requested resource and \
> the resulting KIO job ends up doing a redirection, the SSL related meta-data \
> information will be completely lost. This causes problems like the one mentioned in \
> comment #14 of bug report 154060. This patch addresses this issue, of not retaining \
> the SSL related meta-data items, by connecting to the KIO job's redirection signal \
> and saving the meta-datas whenever appropriate. 
> NOTE: this patch is NOT the complete fix for the 154060! It is only a partial fix \
> as it pertains to the KPart's library. For a complete fix 154060, the KParts \
> themselves have to be updated to catch all SSL related meta-data whenever a \
> container application calls their openUrl(...) function. For details, see the \
> implementation of kwebkitpart's openUrl. 
> 
> This addresses bug 154060.
> https://bugs.kde.org/show_bug.cgi?id=154060
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kparts/browserrun.h 1106566 
> trunk/KDE/kdelibs/kparts/browserrun.cpp 1106566 
> 
> Diff: http://reviewboard.kde.org/r/3364/diff
> 
> 
> Testing
> -------
> 
> Used the link in comment #14 of bug 154060 to test the fix. It works correctly in \
> Konqueror + kwebkitpart with the fix. 
> 
> Thanks,
> 
> Dawit
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]