[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Have RegExp.prototype.test set lastIndex like
From:       peter () pcc ! me ! uk
Date:       2010-03-20 22:35:32
Message-ID: 20100320223532.30515.85071 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3327/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Have RegExp.prototype.test set lastIndex like Regexp.prototype.exec

The EMCAScript specification states that Regexp.prototype.test
acts exactly like Regexp.prototype.exec except for returning a
boolean result.  The kjs implementation currently does not conform
to this because it does not set lastIndex if the global flag is set.
This patch causes it to do so.


Diffs
-----

  trunk/KDE/kdelibs/kjs/regexp_object.cpp 1105683 

Diff: http://reviewboard.kde.org/r/3327/diff


Testing
-------


Thanks,

pcc


[prev in list] [next in list] [prev in thread] [next in thread]