From kde-core-devel  Fri Feb 26 22:29:16 2010
From: "Jaroslaw Staniek" <staniek () kde ! org>
Date: Fri, 26 Feb 2010 22:29:16 +0000
To: kde-core-devel
Subject: Re: Review Request: SQLite version handling improvements (FindSqlite
Message-Id: <20100226222916.19534.9450 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=126722396717632


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2772/
-----------------------------------------------------------

(Updated 2010-02-26 22:29:16.321001)


Review request for kdelibs and Alexander Neundorf.


Changes
-------

- use Sqlite_FIND_VERSION* of cmake 2.6
- provide variables for reuse
- better docs


Summary
-------

The feature set differs from version to version in case of SQLite. Distributions do not allow to install many versions of SQLite side-by-side, so applications that use SQLite without embedding its source code need to carefully check for features available. Otherwise, for example, the files modified with SQLite can loose silently backward compatibility. To make the version tracking easier, two input variables are used:

*  SQLITE_MIN_VERSION - e.g. "3.6.16", if defined, older SQLite versions will not be accepted
*  SQLITE_RECOMMENDED_VERSION - "3.6.22", if defined, warning will be displayed for older SQLite versions

This way, checks can be performed earlier - at configure stage.
In addition, version checking is independent of pkg-config tool, so it works on MS Windows in the same way as on Unices.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/cmake/modules/FindSqlite.cmake 1096528 

Diff: http://reviewboard.kde.org/r/2772/diff


Testing
-------

One of the main users of SQLite, KOffice's Kexi, configures and builds fine. Behaviour of the new script is backward-compatible.


Thanks,

Jaroslaw