[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: add KLocale method for getting flag by country code?
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2010-02-21 18:44:52
Message-ID: 201002211844.53345.aacid () kde ! org
[Download RAW message or body]

A Diumenge, 21 de febrer de 2010, Andriy Rysin va escriure:
> It seems there's at least 3 places in kdebase and 3 places in kdelibs where
> the code gets the flag by country code by "concatenating" locale dir, l10n,
> country code and flag.png
> 
> I would assume the other projects do that too.
> 
> Would that make sense to add a method to KLocale, e.g. QString
> getFlagFileName(const QString& countryCode) (khtml_part is only taking the
> file name to use it in <img> tag) and possibly QIcon getFlagIcon(const
> QString& countryCode) ?

Would kind of make sense, would you do a review request in reviewboard with 
the suggested patch? Remember we do use getFoo in getters.

Albert

> 
> Thanks,
> Andriy
[prev in list] [next in list] [prev in thread] [next in thread]