[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Consistent file name sorting in the file browser
From:       "Peter Penz" <peter.penz () gmx ! at>
Date:       2010-02-21 10:46:49
Message-ID: 20100221104649.10136.21348 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2988/#review4239
-----------------------------------------------------------

Ship it!


I've just tried it and works perfect! Very good: This also bypasses the \
glibc-locale-aware-compare issue mentioned at bug 181211. Do you haven SVN success already? \
Otherwise I'll commit the patch for you...

- Peter


On 2010-02-19 19:09:07, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2988/
> -----------------------------------------------------------
> 
> (Updated 2010-02-19 19:09:07)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> In the KDE file manager, there is an inconsistency when sorting by file names when the files \
> have extensions and when they don't.  So, for example, when there is no extension test1 < \
> test1a < test2 < test 10 < test10a < test20.  But when there is an extension you get \
> something like test1a.txt < test1.txt < test2.txt < test10a.txt < test10.txt < test20.txt.  \
> According to the guide that KDE is using for sorting, \
> http://sourcefrog.net/projects/natsort/, the case without extensions is the correct one.  So \
> what this patch does is first compares the filenames without the extension.  If those don't \
> match, it uses that.  If they do match, it compare the extension.  If there are multiple \
> extensions, it compares each extension in sequence.  If the number of extensions do not \
> match, it treats the file with the fewer extensions as having enough empty extensions to make \
> the two files equal.  This fixes the problem without needing any change to the underlying \
> sorting algorithm.s 
> 
> This addresses bug 201101.
> https://bugs.kde.org/show_bug.cgi?id=201101
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdecore/text/kstringhandler.cpp 1091061 
> 
> Diff: http://reviewboard.kde.org/r/2988/diff
> 
> 
> Testing
> -------
> 
> Tried sorting different combinations of names, extensions, and extension numbers.
> 
> 
> Thanks,
> 
> Todd
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]