[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix "open with" list contents and ordering
From:       "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date:       2010-02-20 13:46:28
Message-ID: 20100220134628.17621.93652 () localhost
[Download RAW message or body]



> On 2010-02-20 13:17:25, Andreas Hartmetz wrote:
> > /trunk/KDE/kdelibs/kio/kio/kfileitemactions_p.h, line 55
> > <http://reviewboard.kde.org/r/2984/diff/2/?file=19690#file19690line55>
> > 
> > 1) const serviceRank &
> > 2) There is no need to forward-declare that function here. File-static functions \
> > generate no symbols in release binaries and can save a few bytes and maybe CPU \
> > cycles - the compiler can mangle file static functions any way it wants because \
> > they are guaranteed to be internal to the currently compiled file. Inline (the \
> > keyword as well as just defining the function here, see \
> > http://www.parashift.com/c++-faq-lite/inline-functions.html) has a similar \
> > effect. Feel free to pick the file static approach, inline, or make no change at \
> > all. Strictly speaking you don't need to declare the struct here as well, it \
> > would suffice to do that in the .cpp file.

I did something wrong with reviewboard. Anyway...
Ignore the last sentence. The _p.h is kind of part of the .cpp file and we don't want \
to put the struct into the global namespace.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2984/#review4224
-----------------------------------------------------------


On 2010-02-20 08:59:04, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2984/
> -----------------------------------------------------------
> 
> (Updated 2010-02-20 08:59:04)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> In the Dolphin and Konqueror menu you get when right-clicking on a group of files, \
> there is a sub-menu that lists possible applications you can use to open the file.  \
> This list, however, does not reliably show all of the valid applications when \
> multiple mimetypes are selected.  This patch fixes that problem.  Further, it sorts \
> the list based on a weighting determined by how highly ranked the application is in \
> all of the selected mimetypes.  So the higher average priority of an application \
> across all the selected mimetypes, the higher its position in the menu. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kio/kio/kfileitemactions_p.h 1091061 
> /trunk/KDE/kdelibs/kio/kio/kfileitemactions.cpp 1091061 
> /trunk/KDE/kdelibs/kio/kio/kfileitemactions.h 1091061 
> 
> Diff: http://reviewboard.kde.org/r/2984/diff
> 
> 
> Testing
> -------
> 
> I tested various file types with different combinations of associated applications \
> in different orders. 
> 
> Thanks,
> 
> Todd
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]