[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Permission to backport Content-Disposition fixes to 4.4
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2010-02-20 1:07:11
Message-ID: 201002200207.12185.germain () ebooksfrance ! org
[Download RAW message or body]

Le jeudi 18 février 2010, Rolf Eike Beer a écrit :
> Rolf Eike Beer wrote:
> > Hi all,
> >
> > I would like to backport a bunch of fixes from trunk to 4.4.1 that touch
> > the parsing of Content-Disposition HTTP headers.
>
> [...]
>
> Is that silence just "go ahead" or am I already in everyones killfile?
>
> Eike

The patches look correct as in well-written, but clearly I couldn't help 
reviewing the actual conformance to spec...

So I just went through the set of tests at greenbytes.de/tech/tc2231 that is 
quite exhaustive, and I can confirm your set of patches makes a bunch of those 
pass that didn't previously.
I tested all tests and couldn't observe a regression[*]

Seems more than enough to me to plead for backport..

Greetings,
Germain

(*) btw, the 'dispext' test still didn't seem to work, though the code in 
trunk seems to imply it should... it is still opened inline for me.


[prev in list] [next in list] [prev in thread] [next in thread]