[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Check the list to randomize is not empty in
From:       "Jaime Torres" <jtamate () gmail ! com>
Date:       2010-02-16 11:39:06
Message-ID: 20100216113906.12233.93515 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2915/#review4176
-----------------------------------------------------------

Ship it!


This patch is simple enough, and safe, for me to say Ship It my first time.

- Jaime


On 2010-02-15 20:43:39, Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2915/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 20:43:39)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Checking the list to randomize is not empty fixes several crashes I get using \
> KRandomSequence in various places. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kdecore/util/krandomsequence.h 1090448 
> 
> Diff: http://reviewboard.kde.org/r/2915/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anne-Marie
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]