From kde-core-devel  Fri Feb 12 18:06:47 2010
From: Alexander Neundorf <neundorf () kde ! org>
Date: Fri, 12 Feb 2010 18:06:47 +0000
To: kde-core-devel
Subject: Re: Using dynamic Qt plugins in KAuth
Message-Id: <201002121906.47383.neundorf () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=126599815013088

On Thursday 11 February 2010, Dario Freddi wrote:
> Hello list,
>
> After seeing that ldd'ing libkdecore gives out quite a lot of things due to
> KAuth + polkit-1, I decided it could be a good thing to move backend
> handling to a dynamic plugin architecture, so I did it (patch attached).
>
> I think this approach is better, it does not change anything in API/ABI
> (the only change in public headers is that now a function is exported), I
> tested it and works quite well.
>
> I was wondering if such a change is ok (I still did not commit it) and if
> it's eligible for a backport to 4.4.

I think this part doesn't look good:

@@ -187,4 +191,9 @@
                auth/backends/dbus/dbus_service.stub
          DESTINATION ${DATA_INSTALL_DIR}/kauth COMPONENT Devel)
 
+# Set the various directories
+set(KAUTH_HELPER_PLUGIN_DIR "${QT_PLUGINS_DIR}/kauth/helper")
+set(KAUTH_BACKEND_PLUGIN_DIR "${QT_PLUGINS_DIR}/kauth/backend")
+set(KAUTH_OTHER_PLUGIN_DIR "${QT_PLUGINS_DIR}/kauth/plugins")
+


Because this way these settings are not in the cache and can not be changed by 
the one who builds the package.
So, these variables should be in the cache, and I'm also not sure that they 
should default to a subdir of QT_PLUGINS_DIR. 
I'd say by default everything should go somewhere inside CMAKE_INSTALL_PREFIX.

Do I remember right that we discussed this already once ?

Alex