[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add "Open File Manager" action to KFileDialog
From:       "Harsh J" <qwertymaniac () gmail ! com>
Date:       2010-02-03 3:31:00
Message-ID: 20100203033100.16356.16607 () localhost
[Download RAW message or body]



> On 2010-02-03 00:29:12, David Faure wrote:
> > /trunk/KDE/kdelibs/kfile/kdiroperator.cpp, line 683
> > <http://reviewboard.kde.org/r/2757/diff/6/?file=18195#file18195line683>
> > 
> > "parent" would be a better argument than QApplication::activeWindow()
> > [which could be NULL meanwhile, on a very busy system if the user \
> > manages to switch windows, I think]

Thank you, changed to 'parent' and committed in revision 1084415.


- Harsh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/#review4029
-----------------------------------------------------------


On 2010-01-30 23:33:53, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2757/
> -----------------------------------------------------------
> 
> (Updated 2010-01-30 23:33:53)
> 
> 
> Review request for kdelibs, usability, Shaun Reich, and David Faure.
> 
> 
> Summary
> -------
> 
> Patch proposes to add a "Open File Manager" button (with \
> system-file-manager icon) to the KFileDialog toolbar, alongside the \
> inline preview button. 
> This will open the current Url the dialog is in, in the default file \
> manager (via KRun). 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kfile/kdiroperator.h 1082235 
> /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1082235 
> 
> Diff: http://reviewboard.kde.org/r/2757/diff
> 
> 
> Testing
> -------
> 
> Works with any directory the dialog is currently viewing.
> 
> 
> Screenshots
> -----------
> 
> Open File Manager in Open File dialog toolbar
> http://reviewboard.kde.org/r/2757/s/307/
> 
> 
> Thanks,
> 
> Harsh
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]