[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Displaying Job Progress in Icons - Review Request
From:       "David Faure" <faure () kde ! org>
Date:       2010-02-03 0:00:17
Message-ID: 20100203000017.13003.28285 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2057/#review4026
-----------------------------------------------------------



/branches/work/sok-progress-in-icons/kdelibs/kdeui/jobs/kuiserverjobtracker.cpp
<http://reviewboard.kde.org/r/2057/#comment3403>

    utf8 messup



/branches/work/sok-progress-in-icons/kdelibs/kio/kio/delegateanimationhandler.cpp
<http://reviewboard.kde.org/r/2057/#comment3404>

    please write this in two lines, otherwise it's quite confusing. Did you really \
mean |= ?



/branches/work/sok-progress-in-icons/kdelibs/kio/kio/kdirmodel.h
<http://reviewboard.kde.org/r/2057/#comment3405>

    I guess that's 4.5 now ;)



/branches/work/sok-progress-in-icons/kdelibs/kio/kio/kdirmodel.cpp
<http://reviewboard.kde.org/r/2057/#comment3406>

    Has this code been tested???
    
    It doesn't compile.



/branches/work/sok-progress-in-icons/kdelibs/kio/kio/kdirmodel.cpp
<http://reviewboard.kde.org/r/2057/#comment3407>

    no need to use const & here, the signature used in SIGNAL/SLOT is normalized to \
(QStringList) anyway; so not adding the const & -here- makes connect and disconnect \
slightly faster. Leave it in the actual slot of course.



/branches/work/sok-progress-in-icons/kdelibs/kio/kio/kfileitemdelegate.h
<http://reviewboard.kde.org/r/2057/#comment3408>

    @since 4.5


- David


On 2009-12-23 17:23:23, Shaun Reich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2057/
> -----------------------------------------------------------
> 
> (Updated 2009-12-23 17:23:23)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> This merge request is for the changes I have done (on my branch), along with other \
> changes(but those are just waiting for this review). 
> The branch was for a project that I have done; displaying the job progress on the \
> file/folder icons. It essentially shows the status, as in whether or not there is a \
> job being performed on a certain dest. url, if there is, a download icon will be \
> shown at the corner, with an animation(circles rotating around a focal point), to \
> show that a transfer is happening (download, copy, etc..).  
> It should be pretty subtle, but may need some tweaking.
> 
> 
> I don't really like the KDirModel::setDisplayJobTransfers(bool), and \
> KFileItemDelegate::setDisplayJobTranfers(bool). They sound terrible imo, and seem \
> to go against Nice API Design, but I use them for lack of a better name. Hopefully \
> you guys have some suggestions? 
> Naturally those 2 method properties are off by default, the individual apps should \
> turn it on at their discretion. I will probably do that for Dolphin and the \
> Folderview plasmoid. 
> 
> There was some oddity that I experienced, that seemed like an impossibility (then \
> again, lots of bugs do). It wouldn't stop displaying that a job was happening, but \
> I tracked it down and if anything it would have been the sender (kuiserver)'s \
> issue. But I've tested kuiserver quite rigorously...I'm thinking it is just some \
> problem dealing with the *major* version differences I am running.. *shrug* 
> 
> I can no longer test this branch with my system, as I run trunk and running this \
> really old checkout side by side...well, that was a pain I am not going to go \
> through again, as apps were crashing so often etc.. and I *still* don't have my \
> plasma's desktop activities back up and running, only 2 system monitors on the \
> desktop :) 
> 
> Once it's committed to trunk, I should be able to quickly verify and track down any \
> issues... 
> 
> Diffs
> -----
> 
> /branches/work/sok-progress-in-icons/kdelibs/kdeui/CMakeLists.txt 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kdeui/jobs/kuiserverjobtracker.cpp \
>                 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/delegateanimationhandler.cpp \
>                 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/delegateanimationhandler_p.h \
>                 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/joburlcache.cpp PRE-CREATION 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/kdirmodel.h 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/kdirmodel.cpp 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/kfileitemdelegate.h 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/kfileitemdelegate.cpp 978718 
> /branches/work/sok-progress-in-icons/kdelibs/kio/kio/org.kde.kuiserver.xml \
> PRE-CREATION  
> Diff: http://reviewboard.kde.org/r/2057/diff
> 
> 
> Testing
> -------
> 
> oodles.
> 
> 
> Thanks,
> 
> Shaun
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]