[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Restore ability to select a groups of files in
From:       "Todd" <toddrme2178 () gmail ! com>
Date:       2010-01-30 6:46:12
Message-ID: 20100130064612.5764.47745 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2764/
-----------------------------------------------------------

Review request for Dolphin and kdelibs.


Summary
-------

This patch restores the ability to select a group of files in Dolphin by clicking on \
the group's title.  This is a feature regression between 4.3 and 4.4  Unlike the \
original version, which could only select groups, this implementation allows for \
selecting and deselecting groups (Peter Penz said he considered the lack of \
deselecting to be a bug).  

The patch also removes a workaround in Dolphin that does not appear to be necessary \
anymore and was preventing the group selection from working.  

I know this is probably not the prettiest solution, but it does work.  I made a \
couple of speed improvements in corner cases, which should be clear from the diff, \
but these could be removed without altering the functionality of the code.  I am open \
to suggestions on improvements.  I would also appreciate it if other people tested it \
as well.


This addresses bug 214859.
    https://bugs.kde.org/show_bug.cgi?id=214859


Diffs
-----

  /trunk/KDE/kdebase/apps/dolphin/src/dolphiniconsview.cpp 1082212 
  /trunk/KDE/kdelibs/kdeui/itemviews/kcategorizedview.h 1082212 
  /trunk/KDE/kdelibs/kdeui/itemviews/kcategorizedview.cpp 1082212 
  /trunk/KDE/kdelibs/kdeui/itemviews/kcategorizedview_p.h 1082212 

Diff: http://reviewboard.kde.org/r/2764/diff


Testing
-------

Selected and deselected groups in Dolphin under various circumstances.


Thanks,

Todd


[prev in list] [next in list] [prev in thread] [next in thread]