[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add "Open With" actions to KFileDialog context
From: "David Faure" <faure () kde ! org>
Date: 2010-01-29 19:14:05
Message-ID: 20100129191405.23000.98740 () localhost
[Download RAW message or body]
> On 2010-01-28 20:44:45, David Faure wrote:
> > One could wonder if the file dialog really needs to have "open with" menu items. \
> > After all this dialog is used to select a file (existing or to be created) for \
> > the current application, not for opening files into another application. It seems \
> > some users are starting to expect a mini-file-manager in there, which is not \
> > exactly what it is. Maybe the usability group could give their input about this.
>
> Aaron Seigo wrote:
> "One could wonder if the file dialog really needs to have "open with" menu items."
>
> agreed; what exactly are the use cases for this? right now, i don't see any.
>
> Harsh J wrote:
> I s'pose it could be helpful to quickly open a file in an alternate program \
> (something like the mini-file-manager) without having to hunt it back down in a \
> proper file manager, to check.
> Since the dialogs' last location is usually stored (or set based on some scenario), \
> its easier this way to open an opened file in alternate/other sort of programs - \
> when an application does not provide a direct way to do so.
> Aaron Seigo wrote:
> is this something that people actually do? it's usually possible to imagine a way \
> to use something, but would it actually be used in this manner? is it a workflow we \
> want to enable/encourage?
> to me it really sounds like a work-around for other (possible) inefficiencies. it \
> at least doesn't match the stated purpose of these dialogs.
Yep. I thought we had a "Open this directory in a file manager" button / menu item, \
but I can't find it anymore. If we had that back, then opening a file from the \
current directory in another application would simply be two clicks away. I see the \
point in not having to navigate again there in another app, that's exactly what "open \
a file manager" would solve, in a more generic way than "open with". It can also be \
useful for renaming/moving/copying files, etc. ;)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/#review3948
-----------------------------------------------------------
On 2010-01-28 21:36:52, Harsh J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2757/
> -----------------------------------------------------------
>
> (Updated 2010-01-28 21:36:52)
>
>
> Review request for kdelibs, usability, Shaun Reich, and David Faure.
>
>
> Summary
> -------
>
> This patch proposes to use KFileItemActions class to add "Open With" actions to the \
> context menu of selected file(s) in KDirOperator (which is used by KFileDialog).
> Some points on the implementation:
> * Added the action under the KDirOperator::FileActions flag
> * Made openWithActions (a KFileItemActions object) a member of the private KDO \
> class
> * Initialized the same object in setupActions() method
>
> I suppose I must add something to KDirOperator::updatedSelectionDependentActions() \
> but I don't think its necessary as the selected items are retrieved while setting \
> up this menu itself. Would be better to add a reloader there just in case though. \
> Opinions please?
> Also, is there a way to make the KDirOperator realize the name of the application \
> that's using it? I could use that to block itself out of the suggestions via the \
> traderConstraints. Doesn't look possible afaik.
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1081124
>
> Diff: http://reviewboard.kde.org/r/2757/diff
>
>
> Testing
> -------
>
> * Selected no items and right clicked - no submenu/separator shows.
> * Selected one item - Open With submenu and sometimes (in cases where only one can \
> open) preferred open with option shows.
> * Selected multiple items - Open With submenu and sometimes (in cases where only \
> one can open) preferred open with option shows.
> * Repeat above two with directories successfully shows the same.
>
>
> Screenshots
> -----------
>
> Open With actions in KFileDialog
> http://reviewboard.kde.org/r/2757/s/305/
>
>
> Thanks,
>
> Harsh
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic