[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Broken redirections in handling of webdav when
From:       "Matthew Dawson" <matthew () mjdsystems ! ca>
Date:       2010-01-29 15:52:47
Message-ID: 20100129155247.17919.12808 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2760/
-----------------------------------------------------------

(Updated 2010-01-29 15:52:47.461340)


Review request for kdelibs.


Summary (updated)
-------

When a website holding a webdav repository automatically redirects all http requests \
to https, the webdav handler in kio_http forces the request back to http.  The \
problem occurs as the code assumes the webdav protocol will not change.

This patch fixes the issue by analyzing the returned url, and sets webdav/webdavs \
based on whether the server requested a redirection to http/https respectively (it \
also will handle redirects from webdavs to webdav).  It also includes a fallback to \
the old behaviour if no protocol is specified, or the protocol is not http/https (is \
that even a legal request?  If not I can remove the fallback).

Also, is it ok to backport this patch for KDE SC 4.4?


Diffs
-----

  /trunk/KDE/kdelibs/kioslave/http/http.cpp 1082000 

Diff: http://reviewboard.kde.org/r/2760/diff


Testing (updated)
-------

Locally against a remote server running lighttpd that auto redirects all requests \
from http to https.  The webdav implementation used comes from webcit, included in \
the citadel mail server.  Url was:

webdav://mail.mjdsystems.ca/groupdav

Tested using kioclient (running kioclient get $url and checking debug output).


Thanks,

Matthew


[prev in list] [next in list] [prev in thread] [next in thread]