[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add "Open With" actions to KFileDialog context
From: "Harsh J" <qwertymaniac () gmail ! com>
Date: 2010-01-28 21:28:29
Message-ID: 20100128212829.24260.4429 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/
-----------------------------------------------------------
(Updated 2010-01-28 21:28:29.684871)
Review request for kdelibs, usability, Shaun Reich, and David Faure.
Changes
-------
Added usability group on dfaure's suggestion so it can be discussed if "open with" is \
valid under KFileDialog context menu or not.
Summary
-------
This patch proposes to use KFileItemActions class to add "Open With" actions to the \
context menu of selected file(s) in KDirOperator (which is used by KFileDialog).
Some points on the implementation:
* Added the action under the KDirOperator::FileActions flag
* Made openWithActions (a KFileItemActions object) a member of the private KDO class
* Initialized the same object in setupActions() method
I suppose I must add something to KDirOperator::updatedSelectionDependentActions() \
but I don't think its necessary as the selected items are retrieved while setting up \
this menu itself. Would be better to add a reloader there just in case though. \
Opinions please?
Also, is there a way to make the KDirOperator realize the name of the application \
that's using it? I could use that to block itself out of the suggestions via the \
traderConstraints. Doesn't look possible afaik.
Diffs
-----
/trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1081124
Diff: http://reviewboard.kde.org/r/2757/diff
Testing
-------
* Selected no items and right clicked - no submenu/separator shows.
* Selected one item - Open With submenu and sometimes (in cases where only one can \
open) preferred open with option shows.
* Selected multiple items - Open With submenu and sometimes (in cases where only one \
can open) preferred open with option shows.
* Repeat above two with directories successfully shows the same.
Screenshots
-----------
Open With actions in KFileDialog
http://reviewboard.kde.org/r/2757/s/305/
Thanks,
Harsh
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic