[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: New KGraphicsSignalPlotter class
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-01-28 8:08:40
Message-ID: 201001280008.41443.aseigo () kde ! org
[Download RAW message or body]

On January 27, 2010, John Tapsell wrote:
> avoid this.  I have put a lot of work into KSIgnalPlotter to make it
> faster and better, and it would be nice for the plasma widget to
> benefit from this.

sounds good

> I want to reduce this plasma widget to a bare
> shell that just inherits KGraphicsSignalPlotter and adds on the few
> plasma specifics bits (using theme colors mostly.  Maybe also the SVG
> code)

we can't change what it inherits. it is a QGraphicsWidget, and that has to 
stay that way for API compatibility reasons.

the way to go about this depends on whether KGraphicSignalPlotter has a very 
different API from Plasma::SignalPlotter or not. if the API is the same (or 
close enough) then the job should be easy:

Plasma::SignalPlotter can internally have a KGraphicsSignalPlotter as a child 
in a QLinearLayout and pass on all the API calls to it.

if the API is significantly different (making the "passing on API calls" bit 
infeasible) then we'll have to introduce a new class. obviously, i'd prefer 
avoiding that :)

p.s. this is not the "best" list for discussing plasma API; plasma-
devel@kde.org is a bit more topical, but we can discuss it here if you prefer 
:)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
[prev in list] [next in list] [prev in thread] [next in thread]