[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: visual bug in category text drawing
From:       "Peter Penz" <peter.penz () gmx ! at>
Date:       2010-01-15 11:20:55
Message-ID: 20100115112055.28801.26587 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2609/#review3712
-----------------------------------------------------------

Ship it!


Please commit + backport. I'm not the maintainer of the class, but until Rafael (= \
maintainer) has again more time for KDE [1], I'll take care for maintaining the \
KCategorized* classes.

[1] The chances are good that Rafael will have more time in 2010 for KDE: \
http://www.ereslibre.es/?p=205

- Peter


On 2010-01-15 00:46:14, Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2609/
> -----------------------------------------------------------
> 
> (Updated 2010-01-15 00:46:14)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> this addresses visual bug in category text drawing.
> The text is truncated at the bottom because textRect height is shorten after it has \
> been adjusted to the fontmetrics. I just removed the corresponding line of code 
> 
> This addresses bug 222794.
> https://bugs.kde.org/show_bug.cgi?id=222794
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/itemviews/kcategorydrawer.cpp 1074886 
> 
> Diff: http://reviewboard.kde.org/r/2609/diff
> 
> 
> Testing
> -------
> 
> see screenshots.
> Also tested in amarok->configure amarok->internet services
> 
> 
> Screenshots
> -----------
> 
> before
> http://reviewboard.kde.org/r/2609/s/297/
> after
> http://reviewboard.kde.org/r/2609/s/298/
> 
> 
> Thanks,
> 
> Hugo
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]