[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Add a new KPasswordLineEditidget
From: "Charles Ghislain" <charlyghislain () gmail ! com>
Date: 2010-01-14 13:56:08
Message-ID: 20100114135608.4661.39773 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2591/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
Hi,
I started adding a warning label to kpassworddialog, then i noticed that password \
fields were used at various place outside a kpassworddialog or a knewpassworddialog. \
Take for instance kmail, konversation, kdm, ... I was told the idea is that \
applications should use those dialogs, but the reallity seems different. Implementing \
the capslock warning in a new kpasswordlineedit allow all those apps to get the \
benefits.
This is my first contribution, I'm new to C++ and KDE and Qt in general. I tried \
copying from other sources i found, but there are still issues i can't resolve by \
myself yet :
- Memory leaks : i don't know were is it - should i delete the childeren widgets in \
the destructor?
- Formatting : i guess it refers to the widget having differenc height when the label \
is shown or not. I don't know how to make sure the widget keeps a fixed height even \
if one of his childeren is hidden. I could just set the text to label to a whitespace \
and keep is shown, but i guess there is a proper way.
- Warning color : I used hardcoded red, i didn't find how to use themed colors
- Others issues i don't think of right know.
Thanks,
Charly
This addresses bug 91970.
https://bugs.kde.org/show_bug.cgi?id=91970
Diffs
-----
trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1074640
trunk/KDE/kdelibs/kdeui/widgets/kpasswordlineedit.h PRE-CREATION
trunk/KDE/kdelibs/kdeui/widgets/kpasswordlineedit.cpp PRE-CREATION
trunk/KDE/kdelibs/kdewidgets/kde.widgets 1074640
Diff: http://reviewboard.kde.org/r/2591/diff
Testing
-------
I tested in designer and replaced the password field of kpassworddialog with it.
Thanks,
Charles
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic