[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: New KColorCombo palette
From:       "Davide Bettio" <davide.bettio () kdemail ! net>
Date:       2010-01-11 22:58:58
Message-ID: 20100111225858.32608.69161 () localhost
[Download RAW message or body]



> On 2010-01-10 19:26:37, Michael Pyne wrote:
> > With the minor things mentioned fixed the patch looks good. I didn't see any \
> > areas where the values of KColorCombo actually get serialized (i.e. it deals with \
> > colors directly in the API) so I don't see any other parts that need changed to \
> > modify the colors and their order.

Should I backport this commit?


- Davide


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2476/#review3639
-----------------------------------------------------------


On 2010-01-10 19:57:41, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2476/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 19:57:41)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> New (and nicer) KColorCombo palette with more colors.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1072245 
> 
> Diff: http://reviewboard.kde.org/r/2476/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> old palette
> http://reviewboard.kde.org/r/2476/s/290/
> new palette
> http://reviewboard.kde.org/r/2476/s/291/
> 
> 
> Thanks,
> 
> Davide
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]