[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Patch for KIO::AccessManager that adds support for
From:       adawit () kde ! org
Date:       2009-12-20 21:28:09
Message-ID: 20091220212809.26956.59210 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2424/
-----------------------------------------------------------

(Updated 2009-12-20 21:28:09.523325)


Review request for kdelibs.


Changes
-------

Fixed compilation problem...


Summary
-------

The attached patch addresses a couple of short comings/missing functionality in \
KIO::AccessManager...

#1. Adds support for putting ioslaves on hold in KIO::AccessManager so that a \
connection can be reused whenever a request is handed off to another process or \
application. This is very essential to the kdewebkit module when dealing with the  \
unsupportedContent signal that QWebPage emits. That signal is emitted when a user \
clicks on a video file or a .tgz file for example.

#2. Changes how redirection is handled by KIO::AccessManager. Currently application \
that use KIO::AccessManager always receive a 302 on redirections regardless of what \
the server response was. That is because the HTTP header meta-data is not yet \
available when the redirection signal is received. This patch corrects that by \
changing how the job handling the current request is killed in the redirection \
handling slot. Instead of killing the job quietly, it kills it with the EmitResult \
flag set so that the slot handling the job's finished signal is invoked. At that \
point the HTTP header meta-data is available and the correct data status code is \
propgated upstream...


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kio/kio/accessmanager.h 1063991 
  /trunk/KDE/kdelibs/kio/kio/accessmanager.cpp 1063991 
  /trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h 1063991 
  /trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1063991 

Diff: http://reviewboard.kde.org/r/2424/diff


Testing
-------

Tested on 4.3 branch, but not trunk. If anyone can test compilation of the attached \
patch on trunk that would be great...


Thanks,

adawit


[prev in list] [next in list] [prev in thread] [next in thread]