[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: fix kcombobox memory leak
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-12-19 12:34:58
Message-ID: 20091219123458.18327.78312 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2416/#review3455
-----------------------------------------------------------


Please do not apply this patch.

KComboBox::setLineEdit() calls QComboBox::setLineEdit(), and as documented, that \
takes ownership, so it will be deleted automatically.

And I doubt it could help fixing mentioned bug, which speaks of leaks in kdeinit (and \
they probably aren't leaks, but just growing VM size due to fragmentation).

- Christoph


On 2009-12-19 12:11:20, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2416/
> -----------------------------------------------------------
> 
> (Updated 2009-12-19 12:11:20)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixes the last memory leak that KDE can remove.
> (as always, I've removed the spaces at the end after looking the red boxes in the \
> diff view) 
> 
> This addresses bug 88550.
> https://bugs.kde.org/show_bug.cgi?id=88550
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/widgets/kcombobox.cpp 1063847 
> 
> Diff: http://reviewboard.kde.org/r/2416/diff
> 
> 
> Testing
> -------
> 
> valgrind does not show any kde memory leak in kfind.
> 
> 
> Thanks,
> 
> Jaime
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]