[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add versioning check for thumbnailers.
From:       "Jacopo De Simoi" <wilderkde () gmail ! com>
Date:       2009-12-01 7:42:29
Message-ID: 20091201074229.5750.22844 () localhost
[Download RAW message or body]



> On 2009-11-30 22:34:45, David Faure wrote:
> > Thanks.
> > 
> > I'm just not sure about the "if not set, then it's assumed to be <0". Doesn't \
> > QString().toInt() return 0? Please take a look at the actual default version, but \
> > other than that, ok for commit.

In fact there are two cases:
1) the cached thumbnail has been created with <4.4 (hence no version): then the \
software string will just read "KDE Thumbnail Generator"; in this case the version is \
assumed to be <0; 2) the cached thumbnail has been created with >=4.4 and the \
thumbnailer has no version: then the software string will read "KDE Thumbnail \
Generator <pluginName> (v)", hence it is assumed to be 0. 

So you are perfectly right in case 2, which I forgot to consider. 
I will add a check for the property when writing the metadata; if the \
property.isEmpty() then the software string will read "KDE Thumbnail Generator \
<pluginName>", so that it will again be considered as <0.


- Jacopo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3353
-----------------------------------------------------------


On 2009-11-30 22:22:39, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
> 
> (Updated 2009-11-30 22:22:39)
> 
> 
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
> 
> 
> Summary
> -------
> 
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is \
> defined and if so, checks that the software field in the existing thumbnail matches \
> before using the cached thumbnail.  
> This fixes caching bugs with the improved jpeg thumbnailer.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1056802 
> trunk/KDE/kdelibs/kio/kio/thumbcreator.h 1056802 
> 
> Diff: http://reviewboard.kde.org/r/2282/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]