[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Port KScreenSaver KCM to Qt4/KDE4 classes + Minor
From:       Darío Andrés <andresbajotierra () gmail ! com>
Date:       2009-11-16 14:40:45
Message-ID: 20091116144045.23514.78921 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1972/
-----------------------------------------------------------

(Updated 2009-11-16 14:40:45.234837)


Review request for kdelibs.


Changes
-------

- Patch updated to the UI changes by Davide Bettio (extracting UI to an external \
                file). I also fixed the layout of the UI a bit.
- License added to the files as all the people agreed on using it (I couldn't contact \
                Martin R. Jones). Is it ok ? did I do some mistake with this ?
- Removed some trailing spaces

If anything is OK I would like to commit it.

Regards


Summary
-------

Changes:
Q3ListView/Q3ListViewItem -> QTreeWidget/QTreeWidgetItem
K3Process -> KProcess
Removed saverlist.h|cpp (it was not necesary, QList<> provides sorting if the type \
implements the "<" operator, which I implemented for SaverConfig) Removed the \
Qt3Support definition 

Fixed the includes order and naming.
Fixed some issues reported by krazy2 checks

- There are still some krazy2 issues to fix, and I would like to export the GUI to an \
external UI file. But that could wait...

- Also, a lot of files are missing a valid license (I don't know how this should be \
handled)

-- 

Further work: move(or remove) the libc includes


Diffs (updated)
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/CMakeLists.txt \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.cpp \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/kssmonitor.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/kswidget.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/kswidget.cpp \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverconfig.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverconfig.cpp \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverlist.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverlist.cpp \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/screensaver.ui \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/testwin.h \
1049568   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/testwin.cpp \
1049568 

Diff: http://reviewboard.kde.org/r/1972/diff


Testing
-------

The KCM works properly, but further test/checks may be needed.


Thanks,

Darío


[prev in list] [next in list] [prev in thread] [next in thread]