[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Patch to show SHA1 sum for certs in KDE SSL
From:       "Tim Brown" <kde () machine ! org ! uk>
Date:       2009-11-13 12:20:51
Message-ID: 20091113122051.2325.47065 () localhost
[Download RAW message or body]



> On 2009-11-03 19:02:21, David Faure wrote:
> > /trunk/KDE/kdelibs/kio/kssl/sslinfo.ui, line 222
> > <http://reviewboard.kde.org/r/2035/diff/1/?file=13616#file13616line222>
> > 
> > Why the sample value here? It just seems to increase the risk of being displayed \
> > if the code ever forgets to setText on the label.

Hey David,

That's just because I took the MD5 line as an example.  No problem to remove the \
sample value from my side.  Maybe both hashes should be set to "unknown" or something \
by default?  Feels nice to give you guys a fix for once and not just advisories :).  \
What happens now, I couldn't find maelcum(?) to do the commit for me.

Tim


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2035/#review2910
-----------------------------------------------------------


On 2009-11-02 02:18:44, Tim Brown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2035/
> -----------------------------------------------------------
> 
> (Updated 2009-11-02 02:18:44)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Konqueror only does not display the SHA1 sum for the cert in the KDE SSL \
> Information window.  MD5 is broken and subject to chosen prefix attacks.  The \
> supplied patch displays the SHA1 sum. 
> 
> This addresses bug 204849.
> https://bugs.kde.org/show_bug.cgi?id=204849
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kio/kssl/ksslinfodialog.cpp 1042515 
> /trunk/KDE/kdelibs/kio/kssl/sslinfo.ui 1042515 
> 
> Diff: http://reviewboard.kde.org/r/2035/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tim
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]