[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Move suggestions menu for misspelled word on top.
From:       "Harsh J" <qwertymaniac () gmail ! com>
Date:       2009-11-10 9:04:30
Message-ID: 20091110090430.24683.31406 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2097/
-----------------------------------------------------------

(Updated 2009-11-10 09:04:30.008269)


Review request for kdelibs.


Changes
-------

Added a top-level change. Not sure if putting them out of a pop-up is a good UI idea, \
cause it might lengthen it a lot for certain words.

Tested again, diff 2 too works fine for both count==0 and otherwise.


Summary (updated)
-------

Minor fix for the Bug 194979.

Bug-report requests that "Suggestions" in the context menu of spell-checker for a \
word, be moved to top instead of last.

Re-ordered the menu/action-adding code in KTextEdit to make the spelling \
"suggestions" appear first.

(Diff 1 keeps them in a popup, diff 2 moves them to top level - as in screenshots)


This addresses bug 194979.
    https://bugs.kde.org/show_bug.cgi?id=194979


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp 1046992 

Diff: http://reviewboard.kde.org/r/2097/diff


Testing (updated)
-------

Recompiled kdelibs and the superficial change appears fine.


Screenshots
-----------

Moved to top entry - suggestions
  http://reviewboard.kde.org/r/2097/s/256/
Moved to top level - suggestions
  http://reviewboard.kde.org/r/2097/s/257/


Thanks,

Harsh


[prev in list] [next in list] [prev in thread] [next in thread]