[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Add WebDav REPORT query to KIO
From:       David Faure <faure () kde ! org>
Date:       2009-11-03 18:58:04
Message-ID: 200911031958.05002.faure () kde ! org
[Download RAW message or body]

On Monday 02 November 2009, Grégory Oestreicher wrote:
> [Repost of this message to the right ML after being redirected here. 
Sorry
>  for the inconvenience to the kde-devel reader]
> 
> Hi,
> 
> Here is a patch against the SVN trunk that adds the WebDav REPORT 
query
>  (RFC 3253). It's mostly a copy-and-paste of other methods and it 
works OK
>  for me against the CalDav implementations I could test.
> 
> This is required for Akonadi CalDav support, which should be 
released soon.

- missing @since 4.4 in the new public davReport method
- why take a QDomDocument? This prevents any other means of 
creating XML, like QXMLStreamWriter, or having it in memory by any
other means. I suggest taking a QString as parameter instead, it's easy
enough for the QDomDocument users to call toString().

Looks fine otherwise.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror 
(http://www.konqueror.org).

[prev in list] [next in list] [prev in thread] [next in thread]