From kde-core-devel  Thu Oct 29 16:55:45 2009
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Thu, 29 Oct 2009 16:55:45 +0000
To: kde-core-devel
Subject: Re: kdewebkit moved to kdereview
Message-Id: <200910291055.55688.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125683543411047
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart3646979.XgMQ7GkgxO"

--nextPart3646979.XgMQ7GkgxO
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On October 29, 2009, Dawit A. wrote:
> On Wednesday 28 October 2009 10:07:55 Marco Martin wrote:
> > On Wednesday 28 October 2009, Dawit A. wrote:
> > > On Tuesday 27 October 2009 22:02:10 Chani wrote:
> > > > > > i ask because there is now a QGraphicsWebView included with
> > > > > > QtWebkit which Plasma eventually will be using instead of our o=
wn
> > > > > > QWebPage-behind-a- QGraphicsWidget implementation that we
> > > > > > currently use; being able to set the KWebPage on a
> > > > > > QGraphicsWebView and get everything, including KWallet
> > > > > > integration, would be optimal.
> > > > >
> > > > > That is exactly the kind of thing KWebPage is actually designed to
> > > > > solve. You use it in place of its Qt counter part to get all of t=
he
> > > > > KDE integration for free...
> > > >
> > > > yes but in plasma we need a *graphics*widget, not a widget. are you
> > > > going to provide that?
> > >
> > > Well if you mean are we going to provide a KDE re-implementaion of
> > > QGraphicsWebView, then there is no plan to do that at this point.
> >
> > nope, because we can't use a QWidget at all, too overhead for a thing
> > like that
>=20
> Unlike QWebView QGraphicsWebView inherits from QGraphicsWidget not
>  QWidget...

i think you're both saying the same thing. regardless, i think we really ou=
ght=20
to have a KGraphicsWebView subclass of QGrahpicsWebView that is an analog f=
or=20
KWebView. this will make it easier to track changes in KWebKit. if you're c=
ool=20
with that, i'd be happy to add such a thing to KWebKit. it would include th=
e=20
same add-on features as in KWebView:

* consistent mouse button keyboard modifiers

* external content access control

in fact, i'd probably put all the logic for this in a share private class a=
nd=20
then have the private classes subclass from that. this would prevent code=20
duplication from creeping in over time.

would you be cool with that? (i'm already nearly done, hoping you'll say ye=
s,=20
in fact ;)

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

--nextPart3646979.XgMQ7GkgxO
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkrpyRsACgkQ1rcusafx20O1UwCdGsV7bsbO6xQvCgsS5dPb6Npa
Qb4AoK8n5p8/afukIySBFw3Tf6gyP8TB
=IwGB
-----END PGP SIGNATURE-----

--nextPart3646979.XgMQ7GkgxO--