[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Make KSqueezedTextLabel::text() return the full
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-10-28 20:19:52
Message-ID: 20091028201952.2775.33398 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1985/#review2844
-----------------------------------------------------------


yes, i think it will need to be a new method (fullText sounds good to me?) otherwise \
the behaviour will differ based on the kind of pointer one is dealing with.


trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.h
<http://reviewboard.kde.org/r/1985/#comment2203>

    missing a ';'?


- Aaron


On 2009-10-27 12:30:53, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1985/
> -----------------------------------------------------------
> 
> (Updated 2009-10-27 12:30:53)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KSqueezedTextLabel is a nice convenience class but its text method does return the \
> squeezed test which is useless. Thus, I reimplemented the text method. The only \
> problem with this is: QLabel::text is not virtual. So the question is: should I \
> rename it to fullText()? 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.h 1037952 
> trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.cpp 1037952 
> 
> Diff: http://reviewboard.kde.org/r/1985/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]