[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: html_canvasimpl.cpp:1190: warning: suggest
From:       Fredrik_Höglund <fredrik () kde ! org>
Date:       2009-10-27 22:57:35
Message-ID: 20091027225735.7269.67804 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1925/#review2839
-----------------------------------------------------------

Ship it!


Looks good, but remove the previous version of that statement before committing.
There is no reason to keep it around.

- Fredrik


On 2009-10-21 19:39:27, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1925/
> -----------------------------------------------------------
> 
> (Updated 2009-10-21 19:39:27)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> he dashboard
> http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdelibs/khtml/html/html_canvasimpl.cpp:1190: warning: suggest parentheses \
> around arithmetic in operand of | 
> at
> void CanvasContext2DImpl::drawPathWithShadow(QPainter *p, const QPainterPath &path, \
> PathPaintOp op, PaintFlags flags) const 
> my proposal: complete with some more parentheses
> see: html_canvasimpl-gm-26.diff
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/khtml/html/html_canvasimpl.cpp 1038700 
> 
> Diff: http://reviewboard.kde.org/r/1925/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]