From kde-core-devel  Tue Oct 27 18:50:00 2009
From: "Aaron Seigo" <aseigo () kde ! org>
Date: Tue, 27 Oct 2009 18:50:00 +0000
To: kde-core-devel
Subject: Re: Review Request: Port KScreenSaver KCM to Qt4/KDE4 classes + Minor
Message-Id: <20091027185000.2414.91816 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125666946829638


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1972/#review2834
-----------------------------------------------------------


"- Also, a lot of files are missing a valid license (I don't know how this should be handled)"

the authors will need to be contacted to confirm licensing.

- Aaron


On 2009-10-25 20:08:10, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1972/
> -----------------------------------------------------------
> 
> (Updated 2009-10-25 20:08:10)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Changes:
> Q3ListView/Q3ListViewItem -> QTreeWidget/QTreeWidgetItem
> K3Process -> KProcess
> Removed saverlist.h|cpp (it was not necesary, QList<> provides sorting if the type implements the "<" operator, which I implemented for SaverConfig)
> Removed the Qt3Support definition 
> 
> Fixed the includes order and naming.
> Fixed some issues reported by krazy2 checks
> 
> - There are still some krazy2 issues to fix, and I would like to export the GUI to an external UI file. But that could wait...
> 
> - Also, a lot of files are missing a valid license (I don't know how this should be handled)
> 
> -- 
> 
> Further work: move(or remove) the libc includes
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/CMakeLists.txt 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.h 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.cpp 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverconfig.h 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverconfig.cpp 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverlist.h 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/saverlist.cpp 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h 1038788 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp 1038788 
> 
> Diff: http://reviewboard.kde.org/r/1972/diff
> 
> 
> Testing
> -------
> 
> The KCM works properly, but further test/checks may be needed.
> 
> 
> Thanks,
> 
> Darío
> 
>