From kde-core-devel Tue Oct 27 12:30:53 2009 From: "Sebastian Trueg" Date: Tue, 27 Oct 2009 12:30:53 +0000 To: kde-core-devel Subject: Review Request: Make KSqueezedTextLabel::text() return the full text Message-Id: <20091027123053.25136.73418 () localhost> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125664670120337 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1985/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- KSqueezedTextLabel is a nice convenience class but its text method does return the squeezed test which is useless. Thus, I reimplemented the text method. The only problem with this is: QLabel::text is not virtual. So the question is: should I rename it to fullText()? Diffs ----- trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.h 1037952 trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.cpp 1037952 Diff: http://reviewboard.kde.org/r/1985/diff Testing ------- Thanks, Sebastian