[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Make KDirWatch inotify threaded.
From:       "Sebastian Sauer" <mail () dipe ! org>
Date:       2009-10-26 22:15:16
Message-ID: 20091026221516.7127.76805 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1963/
-----------------------------------------------------------

(Updated 2009-10-26 22:15:16.054805)


Review request for kdelibs.


Changes
-------

Updated
-  client->watchingStopped = d->_isStopped;
+  client->watchingStopped = instance->d->_isStopped;
to use the instance like before.


Summary
-------

Problem;
Under heavy hd load (e.g. compiling KDE) KDirWatch may freeze for fractions of \
seconds or even longer.

Solution;
Do the same QFileSystemWatcher (qt/src/corelib/io/qfilesystemwatcher_inotify.cpp) \
does and make the QSocketNotifier+inotifyEventReceived logic threaded.

Warning;
This *needs* review.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kio/kio/kdirwatch.h 1038809 
  /trunk/KDE/kdelibs/kio/kio/kdirwatch.cpp 1038809 
  /trunk/KDE/kdelibs/kio/kio/kdirwatch_p.h 1038809 

Diff: http://reviewboard.kde.org/r/1963/diff


Testing
-------

kdelibs/kio/tests/kdirwatch, kdelibs/kio/tests/kdirwatch_gui


Thanks,

Sebastian


[prev in list] [next in list] [prev in thread] [next in thread]